You're forgetting another set of eigenfunctions: $\cos(\frac{(2k+1)\pi}{2a}x)$ for $k\in\mathbb{N}$. In fact, the full set of eigenfunctions are $$\cos\left(\frac{n\pi}{2a}x\right) ~~ \text{for odd } n = 1,3,5,\ldots$$ $$\sin\left(\frac{n\pi}{2a}x\right) ~~ \text{for even } n = 2,4,6,\ldots$$ As you can see, the first eigenfunction $\cos(\pi x/2a)$ is positive everywhere in $(-a,a)$.