`bash` conditional expression `-v var` check if _shell variable_ named `var` is set.
When using `[[ -v $1 ]]`, you actually checked whether a variable named by content of `$1` was set. In your example, it means `$cd`, which was never set.
You can simply check if `$1` is non-empty string, using `-n`:
function abash {
if [[ -n "$1" ]]
then
atom ~/Shell/"$1.sh"
else
atom ~/.bashrc
fi
}
* * *
Note that `var` must be a _shell variable_ for `-v var` work. `[[ -v 1 ]]` will never work because `1` is denoted for _positional parameter_.